Skip to content

[Messenger] Make 'headers' key optional for encoded messages #30466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Mar 6, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30455
License MIT

@nicolas-grekas
Copy link
Member

4.2?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies to 4.2, would be legit to have it there to me also.

@yceruto yceruto changed the base branch from master to 4.2 March 7, 2019 12:33
@yceruto
Copy link
Member Author

yceruto commented Mar 7, 2019

Rebased to 4.2

@fabpot
Copy link
Member

fabpot commented Mar 9, 2019

Thank you @yceruto.

@fabpot fabpot merged commit bb881c9 into symfony:4.2 Mar 9, 2019
fabpot added a commit that referenced this pull request Mar 9, 2019
…es (yceruto)

This PR was merged into the 4.2 branch.

Discussion
----------

[Messenger] Make 'headers' key optional for encoded messages

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30455
| License       | MIT

Commits
-------

bb881c9 Make 'headers' key optional for encoded messages
@fabpot fabpot mentioned this pull request Apr 2, 2019
@yceruto yceruto deleted the fix_30455 branch April 7, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants