Create a hyperlink to interfaces/classes that can be autowired #30469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
|
Hi @nicolas-grekas, Thanks for your review. I still have the problem with that the service alias is getting linked too. Do you know where I should look at? edit: might be a problem of zsh (I think it assumes that cache.app is a url) |
OskarStark
requested changes
Mar 7, 2019
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/console.xml
Outdated
Show resolved
Hide resolved
|
Status: Needs Review |
javiereguiluz
approved these changes
Mar 14, 2019
|
Thank you @SerkanYildiz. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 15, 2019
…utowired (SerkanYildiz) This PR was squashed before being merged into the 4.3-dev branch (closes #30469). Discussion ---------- Create a hyperlink to interfaces/classes that can be autowired | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Added hyperlink to definition of interfaces/classes that can be used for autowiring. But I need help with: - the aliases are becoming hyperlinks too, but shouldn't. It's outputting `<fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>` - it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option. Commits ------- a3dfcee Create a hyperlink to interfaces/classes that can be autowired
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hyperlink to definition of interfaces/classes that can be used for autowiring.
But I need help with:
the aliases are becoming hyperlinks too, but shouldn't.
It's outputting
<fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option.