[HttpClient] add ResponseInterface::toArray() #30499
Conversation
| } | ||
|
|
||
| if (!\is_array($content)) { | ||
| throw new JsonException(sprintf('Response returned %s while an array was expected.', \gettype($content))); |
There was a problem hiding this comment.
updated to:
JSON content was expected to decode to an array, %s returned.
117a1f6 to
aabd1d4
Compare
| @@ -59,6 +59,18 @@ public function getHeaders(bool $throw = true): array; | |||
| */ | |||
| public function getContent(bool $throw = true): string; | |||
|
|
|||
| /** | |||
| * Gets the response body decoded as array, typically from a JSON payload. | |||
There was a problem hiding this comment.
does this mean component will deal with e.g. XML if requested? What if ppl want to leverage a serializer for this?
Honestly, do want the API? :D
From #30502
ppl can always encode/decode on their own if they really want precise control on these
yet, we kinda want this 30+ line method :) should it be util instead?
There was a problem hiding this comment.
Integration with Serializer should be provided by decoration.
There was a problem hiding this comment.
Note I see no reasons why integration with Serializer should implement HttpClientInterface: turning strings (even when coming from response bodies) to objects is not the domain of an http client to me.
There was a problem hiding this comment.
In that case i think we need to update the description to something like Gets a decoded body array representation (typically ...).
Let's say i decorate this toArray to mutate data, but im passing this client globally around in my app; some services might be effected by this.
There was a problem hiding this comment.
🤔 I'm not sure to spot the difference, semantically :)
There was a problem hiding this comment.
Missed your comment, you're right we can expect HTTP domain; thus the body decoded as-is.
👍 with a simple decoration solution for extension in the future.
There was a problem hiding this comment.
that would also help #30494 btw
…-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] add ResponseInterface::toArray() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I'd like we discuss adding a `toArray()` method to `ResponseInterface`. JSON responses are so common when doing server-side requests that this may help remove boilerplate - especially the logic dealing with errors. WDYT? (about flags, I don't think we should make them configurable: if one really needs to deal with custom flags, there's always `ResponseInterface::getContent()` - but it should be very rare.). Commits ------- aabd1d4 [HttpClient] add ResponseInterface::toArray()
I'd like we discuss adding a
toArray()method toResponseInterface.JSON responses are so common when doing server-side requests that this may help remove boilerplate - especially the logic dealing with errors.
WDYT?
(about flags, I don't think we should make them configurable: if one really needs to deal with custom flags, there's always
ResponseInterface::getContent()- but it should be very rare.).