Skip to content

[Form] Fix debug form when using partial type name #30509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Mar 10, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT

Since #29452 (4.3) we have the possibility of passing a partial type name. This fixes the case where debug:form dateTime doesn't work as expected:

In FormRegistry.php line 89:
                                                                                                        
  [Symfony\Component\Form\Exception\InvalidArgumentException]                                           
  Could not load type "dateTime": class does not implement "Symfony\Component\Form\FormTypeInterface". 

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 22b20ca into symfony:master Mar 13, 2019
nicolas-grekas added a commit that referenced this pull request Mar 13, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] Fix debug form when using partial type name

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Since #29452 (4.3) we have the possibility of passing a partial type name. This fixes the case where `debug:form dateTime` doesn't work as expected:
```bash
In FormRegistry.php line 89:

  [Symfony\Component\Form\Exception\InvalidArgumentException]
  Could not load type "dateTime": class does not implement "Symfony\Component\Form\FormTypeInterface".
```

Commits
-------

22b20ca Fix debug:form dateTime
@yceruto yceruto deleted the fix_debug_form branch March 13, 2019 16:13
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants