[Workflow] Fixed BC break with MarkingStoreInterface::setMarking()
#30530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Mar 12, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #30524 |
| License | MIT |
| Doc PR |
xabbuh
previously requested changes
Mar 12, 2019
|
@xabbuh @nicolas-grekas Thanks for your feedback. I addressed them. But the trick with the extra argument does not work for me :/ |
|
|
|
@nicolas-grekas Good catch. I removed the thirs param on both implem (not used anyway). More over, I will deprecate theses implemems in another PR |
nicolas-grekas
approved these changes
Mar 13, 2019
lyrixx
added a commit
that referenced
this pull request
Mar 13, 2019
…Marking()` (lyrixx) This PR was merged into the 4.3-dev branch. Discussion ---------- [Workflow] Fixed BC break with `MarkingStoreInterface::setMarking()` | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #30524 | License | MIT | Doc PR | Commits ------- 7a94e5e [Workflow] Fixed BC break with `MarkingStoreInterface::setMarking()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.