[HttpClient] Add new bearer option #30547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about it, but do we really need it, when the alternative is that one? Yes, it's shorter, but adding the option means added burden when implementing the interface. |
|
Using a Bearer token is very common when requesting an API (more common than Basic). Also, it can be error prone (for instance, your example is wrong because the |
|
Regarding the burden, as this trait isn't internal, it should not be a big deal. |
6c793d5 to
190258f
Compare
nicolas-grekas
approved these changes
Mar 13, 2019
javiereguiluz
approved these changes
Mar 13, 2019
weaverryan
approved these changes
Mar 13, 2019
fabpot
approved these changes
Mar 14, 2019
f262b78 to
f79ef21
Compare
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30547). Discussion ---------- [HttpClient] Add new bearer option | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes<!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a Add a new "auth_bearer" option to set the corresponding flavor of the `Authorization` header as defined in RFC 6750 and used in OAuth (and others). Also rename "auth" to "auth_basic" for consistency as discussed with @nicolas-grekas. Commits ------- f79ef21 [HttpClient] Add new bearer option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "auth_bearer" option to set the corresponding flavor of the
Authorizationheader as defined in RFC 6750 and used in OAuth (and others).Also rename "auth" to "auth_basic" for consistency as discussed with @nicolas-grekas.