[HttpClient] Make exceptions public #30549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Mar 17, 2019
9f985b4 to
928d774
Compare
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30549). Discussion ---------- [HttpClient] Make exceptions public | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no<!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a Makes it easier to implement the interface. See api-platform/core#2608 Commits ------- 928d774 [HttpClient] Make exceptions public
fabpot
added a commit
that referenced
this pull request
May 10, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpClient] add TimeoutExceptionInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This is fixing a design issue: unlike any other `TransportExceptionInterface`, timeouts are not fatal transport errors. For this reason, we must allow one to identify them. ~This PR also marks exception classes as `@internal`, to encourage ppl to catch them using their interface and not their class name.~ this would revert #30549 Commits ------- ab8eca0 [HttpClient] add TimeoutExceptionInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to implement the interface. See api-platform/core#2608