[Cache] fix LockRegistry #30576
Merged
[Cache] fix LockRegistry #30576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebd7194 to
13f40b7
Compare
13f40b7 to
f49df4a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Mar 15, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [Cache] fix LockRegistry | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - - Locking doesn't work right now, because of this missing return statement. I can't provide a useful test case, because this is effective only when race conditions happen... - Writing the value should happen within the boundaries of the lock. - The `final` keyword is really missing, there are zero reasons to extend this class, adding it asap will make it clear and will unlock progress on this class. - Lastly, a type-hint fix is shipped here also. Commits ------- f49df4a [Cache] fix LockRegistry
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't provide a useful test case, because this is effective only when race conditions happen...
finalkeyword is really missing, there are zero reasons to extend this class, adding it asap will make it clear and will unlock progress on this class.