Skip to content

[Messenger] Display a nice error when connection fail #30583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2019
Merged

[Messenger] Display a nice error when connection fail #30583

merged 1 commit into from
Mar 17, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 16, 2019

Q A
Branch? master
Bug fix? no
New feature? kind of
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Before:

image

Now:

image

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 16, 2019
@lyrixx lyrixx force-pushed the messenger-connect-fail branch from c73c919 to eac014f Compare March 17, 2019 12:27
@fabpot
Copy link
Member

fabpot commented Mar 17, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit eac014f into symfony:master Mar 17, 2019
fabpot added a commit that referenced this pull request Mar 17, 2019
@fabpot
feature #30583 [Messenger] Display a nice error when connection fail …
0c6f0b4 
…(lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Display a nice error when connection fail

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | kind of
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

### Before:

![image](https://user-images.githubusercontent.com/408368/54469293-6bc12f80-4796-11e9-897c-f07504132214.png)

### Now:

![image](https://user-images.githubusercontent.com/408368/54469287-5c41e680-4796-11e9-80ac-692899693542.png)

Commits
-------

eac014f [Messenger] Display a nice error when connection fail
@lyrixx lyrixx deleted the messenger-connect-fail branch March 17, 2019 14:53
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @fabpot @weaverryan @nicolas-grekas @carsonbot