Skip to content

Fixed usage of TranslatorInterface in form extension (fixes #30591) #30593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

althaus
Copy link
Contributor

@althaus althaus commented Mar 18, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30591
License MIT

This PR replaces the fixed usage of the deprecated TranslatorInterface in the form extension with a soft one accepting either the old or the new interface.

@fabpot
Copy link
Member

fabpot commented Mar 19, 2019

Thank you @althaus.

@fabpot fabpot merged commit d8092c7 into symfony:4.2 Mar 19, 2019
fabpot added a commit that referenced this pull request Mar 19, 2019
…#30591) (althaus)

This PR was merged into the 4.2 branch.

Discussion
----------

Fixed usage of TranslatorInterface in form extension (fixes #30591)

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30591
| License       | MIT

This PR replaces the fixed usage of the deprecated TranslatorInterface in the form extension with a soft one accepting either the old or the new interface.

Commits
-------

d8092c7 Fixed usage of TranslatorInterface in form extension (fixes #30591)
@althaus althaus deleted the 30591-form-translator branch March 19, 2019 08:37
@fabpot fabpot mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants