[Finder] Throw a dedicated exception for non-existing directory #30744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Finder::in() throw a DirectoryNotFoundException instead of an InvalidArgumentException if one of the directories is not found. This behavior is more consistent with the AccessDeniedException for files which are unreadable due to insufficient permissions. To keep BC, the new exception class inherits from InvalidArgumentException.
fabpot
approved these changes
Mar 29, 2019
|
Thank you @xelan. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2019
…directory (xelan) This PR was merged into the 4.3-dev branch. Discussion ---------- [Finder] Throw a dedicated exception for non-existing directory | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes [1] | New feature? | yes | BC breaks? | no | Deprecations? | no [2] | Tests pass? | yes | Fixed tickets | #30723 | License | MIT | Doc PR | N/A [3] Makes `Finder::in()` throw a `DirectoryNotFoundException` instead of an `InvalidArgumentException` if one of the directories is not found. This behavior is more consistent with the `AccessDeniedException` for files which are unreadable due to insufficient permissions. To keep backward compatibility, the new exception class inherits from `InvalidArgumentException`. [1] A valid, but non-existent directory name is IMHO not an invalid argument [2] However, it may be semantically better to extend from `RuntimeException`, This would require a deprecation. [3] Possible exceptions are currently not explained at https://symfony.com/doc/current/components/finder.html Commits ------- 48d5f94 Throw a dedicated exception for non-existing directory
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
Finder::in()throw aDirectoryNotFoundExceptioninstead of anInvalidArgumentExceptionif one of the directories is not found.This behavior is more consistent with the
AccessDeniedExceptionfor files which are unreadable due to insufficient permissions.To keep backward compatibility, the new exception class inherits from
InvalidArgumentException.[1] A valid, but non-existent directory name is IMHO not an invalid argument
[2] However, it may be semantically better to extend from
RuntimeException, This would require a deprecation.[3] Possible exceptions are currently not explained at https://symfony.com/doc/current/components/finder.html