Changing to MessageDecodingFailedException so that invalid messages are rejected #30756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
848d156 to
708f652
Compare
|
no updates to tests ? This makes me think some tests are missing (or that the patch is incomplete) |
708f652 to
a4d398e
Compare
a4d398e to
4be827d
Compare
|
Tests added! This should be ready :) |
fabpot
approved these changes
Mar 31, 2019
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2019
… messages are rejected (weaverryan) This PR was merged into the 4.3-dev branch. Discussion ---------- Changing to MessageDecodingFailedException so that invalid messages are rejected | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30649 | License | MIT | Doc PR | not needed for bug fix Bug fix if a message body is completely blank. I'm fixing this on master only, because in 4.2 and earlier, there is actually no system in place to fail serialization and cause the messages to be rejected. In 4.3, we just need to throw this exception. Cheers! Commits ------- 4be827d Changing to MessageDecodingFailedException so that invalid messages are rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix if a message body is completely blank. I'm fixing this on master only, because in 4.2 and earlier, there is actually no system in place to fail serialization and cause the messages to be rejected. In 4.3, we just need to throw this exception.
Cheers!