-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Intl] Update the ICU data to 64.1 #30781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0830697
to
fa95d90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(failures unrelated)
Tests on travis are failing for several reasons:
1 is unrelated and needs to be looked into in separation. |
can't we bump some lowest dep in a composer.json? |
We could, but it's not necessary as the failing test just relies on data too much. I just pushed a change that's hopefully gonna fix it. |
Thank you @jakzal. |
This PR was squashed before being merged into the 3.4 branch (closes #30781). Discussion ---------- [Intl] Update the ICU data to 64.1 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes, including the intl-data group | Fixed tickets | - | License | MIT | Doc PR | - http://site.icu-project.org/download/64 Commits ------- ae2cb6f [Intl] Update the ICU data to 64.1
Looks like this creates merge conflicts with changes made in #30588 (eg |
@nicolas-grekas #28833 was merged into 4.2 (new feature), since filtering languages could be considered a BC break: https://github.com/symfony/intl/blob/45f4510b4fa85f44ad8c588e238f21e06d602ffe/CHANGELOG.md#420 So Intl data updates are merged into lowest branch, but each branch should be re-comiled to apply these filters. |
I'll re-generate data for 4.2 to see if anything needs updating. |
This PR was merged into the 4.2 branch. Discussion ---------- Re-generate icu 64.1 data | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30781 (comment) | License | MIT | Doc PR | - Commits ------- 6fb2c86 Re-generate icu 64.1 data
The fix here seems to be to check if |
@ToonSpinISAAC regardless of what's documented, |
If there's something to fix here it's probably a documentation bug in PHP. If Having said that I don't know what the Symfony team is supposed to do about the above. The reason I'm proposing a check for an empty string is that according to the PHP documentation, the function always returns a string - I don't feel strongly enough about this to be disappointed if the check doesn't happen though. 😄 |
@ToonSpinISAAC I think it should be fixed in the php docs. Previously |
http://site.icu-project.org/download/64