Skip to content

Skip Glob brace test when GLOB_BRACE is unavailable #30839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Skip Glob brace test when GLOB_BRACE is unavailable #30839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Finder/Tests/FinderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,10 @@ public function testInWithNonDirectoryGlob()

public function testInWithGlobBrace()
{
if (!\defined('GLOB_BRACE')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add such a test in the code to alert the developer of the issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can reliably implement this without a glob parser. We already have a glob parser, but not for this purpose (see Glob::toRegex())

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, Zend has implemented a fallback in it's stdlib: https://github.com/zendframework/zend-stdlib/blob/master/src/Glob.php#L89-L168

$this->markTestSkipped('Glob brace is not supported on this system.');
}

$finder = $this->buildFinder();
$finder->in([__DIR__.'/Fixtures/{A,copy/A}/B/C'])->getIterator();

Expand Down