[HttpClient] Add ScopingHttpClient::forBaseUri() + tweak MockHttpClient #30843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Apr 3, 2019
9ed37b0 to
2b9b8e5
Compare
fabpot
approved these changes
Apr 3, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2019
…ak MockHttpClient (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] Add ScopingHttpClient::forBaseUri() + tweak MockHttpClient | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This allows creating scoped HTTP clients in one line: ```php $client = ScopingHttpClient::forBaseUri($client, 'http://example.com'); ``` `$client` now resolves relative URLs using the provided base URI. If one also adds default options as 3rd argument, these will be applied conditionally when a URL matching the base URI is requested. This PR also tweaks `MockHttpClient` to make it return `MockResponse` on its own when no constructor argument is provided, easing tests a bit. Commits ------- 2b9b8e5 [HttpClient] Add ScopingHttpClient::forBaseUri() + tweak MockHttpClient
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creating scoped HTTP clients in one line:
$clientnow resolves relative URLs using the provided base URI.If one also adds default options as 3rd argument, these will be applied conditionally when a URL matching the base URI is requested.
This PR also tweaks
MockHttpClientto make it returnMockResponseon its own when no constructor argument is provided, easing tests a bit.