[FrameworkBundle] fix search in debug autowiring #30887
Conversation
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
cff1c8e to
bfe246c
Compare
src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
Outdated
Show resolved
Hide resolved
cbec3df to
92155ec
Compare
|
@nicolas-grekas updated |
|
I spent my time in debbuging and crating my PR, and i waiting for the back from 24days, @Simperfit it's normal for you to create new PR after the back of @nicolas-grekas ???? @chalasr it's normal to close my PR and not this PR? |
92155ec to
c965a17
Compare
|
@soufianZantar Firstly Thanks very much for the contribution to the Symfony framework, We are at a hackathon, we wanted to move things forward by taking the stalling PRs to finish them. You still have the work done with the commit included in the PR, again thanks very much, I just took what you have done and updated it while talking to @nicolas-grekas. |
c965a17 to
a535bdb
Compare
|
Ok, I understood now. No problem. |
|
If you want to get credit for that PR, you can do so by associating the email address for what seems to be an alternate account (@sez-open ?) to your @soufianZantar account. With love from the hackathon: https://twitter.com/hashtag/EUFOSSA |
a535bdb to
fec4bea
Compare
|
Thank you @Simperfit. |
…open) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] fix search in debug autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30493 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Taking #30522 and finishing it with @nicolas-grekas comments. Is the sentence ok ? Commits ------- fec4bea fix debug:autowiringcommand
|
And thank you @soufianZantar |
Taking #30522 and finishing it with @nicolas-grekas comments.
Is the sentence ok ?