[DependencyInjection] Fix a wrong error when using a factory #30889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6981fff to
9b8397b
Compare
jderusse
approved these changes
Apr 6, 2019
dmaicher
reviewed
Apr 6, 2019
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
ad4c735 to
66f6e8e
Compare
tgalopin
approved these changes
Apr 6, 2019
fabpot
approved these changes
Apr 6, 2019
|
Should probably be applied on 3.4 or 4.2 |
66f6e8e to
5d4e3a2
Compare
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…ry (Simperfit) This PR was merged into the 3.4 branch. Discussion ---------- [DependencyInjection] Fix a wrong error when using a factory …d a call | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30885 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> This a work in progress, it needs tests, firstly I wanted to ask the author to test and tell if it's ok. Commits ------- 5d4e3a2 [WIP] [DependencyInjection] Fix a wrong error when using a factory and a call
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2019
…s pass (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Skip unknown method calls for factories in check types pass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34559 | License | MIT | Doc PR | - Ref #30885 and #30889. Commits ------- 592bff8 [DI] Skip unknown method calls for factories in check types pass
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Nov 28, 2019
…s pass (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Skip unknown method calls for factories in check types pass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#34559 | License | MIT | Doc PR | - Ref symfony/symfony#30885 and symfony/symfony#30889. Commits ------- 592bff88f2 [DI] Skip unknown method calls for factories in check types pass
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Nov 28, 2019
…s pass (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Skip unknown method calls for factories in check types pass | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#34559 | License | MIT | Doc PR | - Ref symfony/symfony#30885 and symfony/symfony#30889. Commits ------- 592bff88f2 [DI] Skip unknown method calls for factories in check types pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d a call
This a work in progress, it needs tests, firstly I wanted to ask the author to test and tell if it's ok.