[DomCrawler] Improve Crawler HTML5 parser need detection #30892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57c9bee to
96b5f69
Compare
|
@tgalopin will you add a config option in FrameworkBundle to enable/disable the HTML5 parser? Thanks. |
derrabus
requested changes
Apr 6, 2019
ostrolucky
suggested changes
Apr 6, 2019
|
@javiereguiluz the usage of the HTML5 parser is when 1/ the library is available 2/ the doctype is HTML5. I think it's better than having a configuration option (and was recommended by Nicolas) |
ostrolucky
reviewed
Apr 6, 2019
stof
requested changes
Apr 6, 2019
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 6, 2019
…(javiereguiluz) This PR was squashed before being merged into the master branch (closes #11316). Discussion ---------- Minor improvement in the DomCrawler + HTML5 explanation Minor improvement according to @tgalopin comments in symfony/symfony#30892. Commits ------- 1c7eb79 Minor improvement in the DomCrawler + HTML5 explanation
96b5f69 to
92cd9ec
Compare
92cd9ec to
9bbdab6
Compare
|
Updated |
maxhelias
approved these changes
Apr 6, 2019
stof
approved these changes
Apr 6, 2019
fabpot
approved these changes
Apr 6, 2019
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…on (tgalopin) This PR was merged into the 4.3-dev branch. Discussion ---------- [DomCrawler] Improve Crawler HTML5 parser need detection | Q | A | ------------- | --- | Branch? | master | Bug fix? | kind of | New feature? | no | BC breaks? | no | Deprecations? | no> | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Live from #eu-fossa Follow up of #29306 This PR introduces a better detection mechanism to choose when to parse using the HTML5 parser or not, and fix a subcrawler parsing issue as well. @stof I'd be super interested by your review :) ! Commits ------- 9bbdab6 [DomCrawler] Improve Crawler HTML5 parser need detection
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 9, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [DomCrawler] fix HTML5 parser integration | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted while reviewing #30892 The current logic is context-dependent: by changing the order of calls, you can get different behaviors. Commits ------- ba83bda [DomCrawler] fix HTML5 parser integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live from #eu-fossa
Follow up of #29306
This PR introduces a better detection mechanism to choose when to parse using the HTML5 parser or not, and fix a subcrawler parsing issue as well.
@stof I'd be super interested by your review :) !