Skip to content

[HttpClient] Fix Notice on HttpClientTestCase::testTimeoutOnStream() #30896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

[HttpClient] Fix Notice on HttpClientTestCase::testTimeoutOnStream() #30896

merged 1 commit into from
Apr 7, 2019

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Apr 6, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

When I run the test suite for the HTTP Client locally, I run into the following notice:

Notice: ob_flush(): failed to flush buffer. No buffer to flush in /path/to/symfony/src/Symfony/Contracts/HttpClient/Test/Fixtures/web/index.php on line 89

This PR aims to fix this.

EUFOSSA

@derrabus derrabus changed the title There is no OB to flush. [HttpClient] Fix Notice on HttpClientTestCase::testTimeoutOnStream() Apr 6, 2019
@chalasr chalasr added this to the next milestone Apr 6, 2019
@dmaicher
Copy link
Contributor

dmaicher commented Apr 6, 2019

This makes the travis tests fail though?

https://travis-ci.org/symfony/symfony/jobs/516576674

1) Symfony\Component\HttpClient\Tests\CurlHttpClientTest::testTimeoutOnStream
Failed asserting that Array &0 (
    0 => 't'
) is identical to Array &0 (
    0 => '<1>'
    1 => 't'
).

@nicolas-grekas
Copy link
Member

Let's just silence the notice

@derrabus derrabus force-pushed the bugfix/http-client-timeout-test branch from 211a982 to 8acf29e Compare April 7, 2019 08:26
@derrabus
Copy link
Member Author

derrabus commented Apr 7, 2019

Let's just silence the notice

That's what I did now.

@fabpot
Copy link
Member

fabpot commented Apr 7, 2019

Thank you @derrabus.

@fabpot fabpot merged commit 8acf29e into symfony:master Apr 7, 2019
fabpot added a commit that referenced this pull request Apr 7, 2019
@fabpot
minor #30896 [HttpClient] Fix Notice on HttpClientTestCase::testTimeo…
680074d 
…utOnStream() (derrabus)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] Fix Notice on HttpClientTestCase::testTimeoutOnStream()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

When I run the test suite for the HTTP Client locally, I run into the following notice:

```
Notice: ob_flush(): failed to flush buffer. No buffer to flush in /path/to/symfony/src/Symfony/Contracts/HttpClient/Test/Fixtures/web/index.php on line 89
```

This PR aims to fix this.

`EUFOSSA`

Commits
-------

8acf29e There is no OB to flush.
@derrabus derrabus deleted the bugfix/http-client-timeout-test branch April 7, 2019 08:32
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
7 participants
@derrabus @dmaicher @nicolas-grekas @fabpot @javiereguiluz @chalasr @carsonbot