[DIC] Add a require env var processor
#30897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Apr 6, 2019
|
Before I forget: Can I (or who can) add the FOSSHackathon label? |
|
I guess tests are failing due to some other issue...? |
|
@mpdude you should add the hashtags in the PR description (allowing to find all these issues and PR through the github search, even on multiple repos) |
|
this requires either a doc PR or at least a doc issue. |
stof
reviewed
Apr 6, 2019
|
Doc PR added. |
@stof Not sure I understand how to do this |
|
Regarding the failed tests, every test run fails due to different reasons. In all cases, I don't see how that would be related to this PR. |
This allows to process .php files, returning the value returned from that file. Leverages the opcache.
60ad78a to
03da3a2
Compare
|
Rebased on master to give Travis/CI tests another try. |
nicolas-grekas
approved these changes
Apr 7, 2019
|
Thank you @mpdude. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [DIC] Add a `require` env var processor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11313 This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!). #EUFOSSA Commits ------- 03da3a2 Add a `require` env var processor
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 7, 2019
…ude) This PR was squashed before being merged into the master branch (closes #11313). Discussion ---------- Add documentation for the `require` env processor Documentation for symfony/symfony#30897, discussed on the FOSSHackathon. Commits ------- 1011b42 Add documentation for the `require` env processor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
requireprocessor that willrequire()the PHP file given as input value and return the valuereturned from that file. Leverages opcaching (yay!).#EUFOSSA