Skip to content

[Workflow] The TransitionEvent is able to modify the context #30902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2019
Merged

[Workflow] The TransitionEvent is able to modify the context #30902

merged 1 commit into from
Apr 6, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 6, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

EUFOSSA

ping @HeahDude

@lyrixx lyrixx force-pushed the workflow-context-event branch from 1fba32b to 62ab775 Compare April 6, 2019 15:06
HeahDude
HeahDude approved these changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xabbuh xabbuh added this to the next milestone Apr 6, 2019
@fabpot
Copy link
Member

fabpot commented Apr 6, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 62ab775 into symfony:master Apr 6, 2019
fabpot added a commit that referenced this pull request Apr 6, 2019
@fabpot
feature #30902 [Workflow] The TransitionEvent is able to modify the c…
e2e38de 
…ontext (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] The TransitionEvent is able to modify the context

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

ping @HeahDude

Commits
-------

62ab775 [Workflow] The TransitionEvent is able to modify the context
@lyrixx lyrixx deleted the workflow-context-event branch April 6, 2019 19:03
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@vudaltsov vudaltsov vudaltsov approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Workflow
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
7 participants
@lyrixx @fabpot @xabbuh @vudaltsov @HeahDude @nicolas-grekas @carsonbot