Skip to content

[Messenger] Uses an AmqpStamp to provide flags and attributes #30913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Apr 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28885
License MIT
Doc PR ø

Using the AmqpStamp you can configure the flags and any attribute (such as delivery_mode).

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

@sroze sroze force-pushed the feature-28885-custom-flags-and-attributes branch 2 times, most recently from df31f55 to ee068a3 Compare April 6, 2019 18:32
@sroze sroze force-pushed the feature-28885-custom-flags-and-attributes branch from ee068a3 to 56fa574 Compare April 6, 2019 19:05
@fabpot
Copy link
Member

fabpot commented Apr 6, 2019

Thank you @sroze.

@fabpot fabpot merged commit 56fa574 into symfony:master Apr 6, 2019
fabpot added a commit that referenced this pull request Apr 6, 2019
…ttributes (sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Uses an `AmqpStamp` to provide flags and attributes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28885
| License       | MIT
| Doc PR        | ø

Using the `AmqpStamp` you can configure the flags and any attribute (such as `delivery_mode`).

Commits
-------

56fa574 Uses an `AmqpStamp` to provide flags and attributes
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants