-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Uses an AmqpStamp
to provide flags and attributes
#30913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:master
from
sroze:feature-28885-custom-flags-and-attributes
Apr 6, 2019
Merged
[Messenger] Uses an AmqpStamp
to provide flags and attributes
#30913
fabpot
merged 1 commit into
symfony:master
from
sroze:feature-28885-custom-flags-and-attributes
Apr 6, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d76faa
to
6d6a5f7
Compare
src/Symfony/Component/Messenger/Transport/AmqpExt/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/AmqpExt/Connection.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
df31f55
to
ee068a3
Compare
ee068a3
to
56fa574
Compare
fabpot
approved these changes
Apr 6, 2019
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…ttributes (sroze) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Uses an `AmqpStamp` to provide flags and attributes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28885 | License | MIT | Doc PR | ø Using the `AmqpStamp` you can configure the flags and any attribute (such as `delivery_mode`). Commits ------- 56fa574 Uses an `AmqpStamp` to provide flags and attributes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
AmqpStamp
you can configure the flags and any attribute (such asdelivery_mode
).