Skip to content

Fix Lock test suite #30944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

Fix Lock test suite #30944

merged 1 commit into from
Apr 7, 2019

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Apr 7, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets na
License MIT
Doc PR na

@chalasr
Copy link
Member

chalasr commented Apr 7, 2019

Still failing :) https://travis-ci.org/symfony/symfony/jobs/516770133#L4050

@fabpot
Copy link
Member

fabpot commented Apr 7, 2019

Tests are still broken apparently.

@sroze
Copy link
Contributor

sroze commented Apr 7, 2019 •
edited
Loading

Still failing on deps=low:

1) Symfony\Component\Lock\Tests\Store\StoreFactoryTest::testCreateStore with data set #7 ('memcached://server.com', 'Symfony\Component\Lock\Store\...dStore')
Error: Class 'Symfony\Component\Cache\Adapter\AbstractAdapter' not found

@jderusse
Copy link
Member Author

jderusse commented Apr 7, 2019

code changed @approvers: (check if the Adapter exists)

@fabpot
Copy link
Member

fabpot commented Apr 7, 2019

Thank you @jderusse.

@fabpot fabpot merged commit 1f66e7b into symfony:master Apr 7, 2019
fabpot added a commit that referenced this pull request Apr 7, 2019
@fabpot
minor #30944 Fix Lock test suite (jderusse)
04eed54 
This PR was merged into the 4.3-dev branch.

Discussion
----------

Fix Lock test suite

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | na
| License       | MIT
| Doc PR        | na

Commits
-------

1f66e7b Fix Lock test suite
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@jderusse jderusse deleted the fix-test branch August 2, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
8 participants
@jderusse @chalasr @fabpot @sroze @lyrixx @nicolas-grekas @lsmith77 @carsonbot