[Security] Add Argon2idPasswordEncoder #30968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac746ec to
7e82a64
Compare
sstok
suggested changes
Apr 7, 2019
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Outdated
Show resolved
Hide resolved
OskarStark
requested changes
Apr 7, 2019
fabpot
approved these changes
Apr 8, 2019
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Apr 8, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Security] Add Argon2idPasswordEncoder | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #28093 | License | MIT | Doc PR | TODO Currently we have a `Argon2iPasswordEncoder` that may hash passwords using `argon2id` instead of `argon2i` (platform-dependent) which is not good. This deprecates producing/validating `argon2id` hashed passwords using the `Argon2iPasswordEncoder`, and adds a `Argon2idPasswordEncoder` able to produce/validate `argon2id` hashed passwords only. #EUFOSSA Commits ------- 0c82173 [Security] Add Argon2idPasswordEncoder
teohhanhui
reviewed
Apr 8, 2019
stof
reviewed
Apr 8, 2019
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Show resolved
Hide resolved
bigfoot90
reviewed
Apr 10, 2019
| public function testEncodersWithArgon2id() | ||
| { | ||
| if (!Argon2idPasswordEncoder::isSupported()) { | ||
| $this->markTestSkipped('Argon2i algorithm is not supported.'); |
There was a problem hiding this comment.
Argon2id algorithm is not supported.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a
Argon2iPasswordEncoderthat may hash passwords usingargon2idinstead ofargon2i(platform-dependent) which is not good.This deprecates producing/validating
argon2idhashed passwords using theArgon2iPasswordEncoder, and adds aArgon2idPasswordEncoderable to produce/validateargon2idhashed passwords only.#EUFOSSA