Fix the configurability of CoreExtension deps in standalone usage #30979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Apr 7, 2019
| /** | ||
| * @param bool $forceCoreExtension | ||
| */ | ||
| public function __construct($forceCoreExtension = false) |
There was a problem hiding this comment.
phpdoc should be replaced by a typehint when merging up to master
xabbuh
reviewed
Apr 7, 2019
xabbuh
approved these changes
Apr 7, 2019
f882444 to
42111f0
Compare
42111f0 to
934118b
Compare
|
Thank you @stof. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
…e usage (stof) This PR was squashed before being merged into the 3.4 branch (closes #30979). Discussion ---------- Fix the configurability of CoreExtension deps in standalone usage | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | not yet, but will allow fixing them | Fixed tickets | n/a | License | MIT | Doc PR | n/a When using the Forms entrypoint to configure the component, there was no chance to configure dependencies of the CoreExtension, as the one registered without argument was first and would win. The builder now delays the prepending of the CoreExtension to do it only if the CoreExtension is not registered explicitly. We discovered that when trying to fix tests for the FileType, where we wanted to pass a Translator to it. Commits ------- 934118b Fix the configurability of CoreExtension deps in standalone usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Forms entrypoint to configure the component, there was no chance to configure dependencies of the CoreExtension, as the one registered without argument was first and would win.
The builder now delays the prepending of the CoreExtension to do it only if the CoreExtension is not registered explicitly.
We discovered that when trying to fix tests for the FileType, where we wanted to pass a Translator to it.