[Validator] Deprecated interface still required for TranslationInterface in Validator #31025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -256,8 +256,11 @@ public function setConstraintValidatorFactory(ConstraintValidatorFactoryInterfac | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function setTranslator(LegacyTranslatorInterface $translator) | |||
| public function setTranslator($translator) | |||
There was a problem hiding this comment.
Changing this is a BC break - but that might be OK as maybe nobody extends this class.
If not, we need to rethink the BC layer.
d247e67 to
4301a56
Compare
|
Accidentally closed this one |
|
Thinking twice, this change is wrong - as in "BC break". |
|
but then, we need to update FrameworkBundle to perform this wrapping. Otherwise, we force the |
|
btw, this also means we don't have a migration path on the ValidatorBuilder for now. |
we have one: the class is made final |
fabpot
pushed a commit
that referenced
this pull request
Apr 17, 2019
…or with LegacyTranslatorProxy (nicolas-grekas) This PR was merged into the 4.2 branch. Discussion ---------- [FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31092, #31025 | License | MIT | Doc PR | - This allows defining a translator that implements only the new interface and use it with ValidatorBuilder. ping @dvdknaap, @snebes since you were affected. Commits ------- a12656e [FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hard requirement for the LegacyValidatorInterface used by replacing the type-hint with a docBlock typehint for either the non-deprecated or deprecated TranslatorInterface.
Also, updated the test to use the new TranslatorInterface contract.