[Serializer] MetadataAwareNameConverter: Do not assume that property names are strings #31031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewome62
approved these changes
Apr 10, 2019
fabpot
approved these changes
Apr 10, 2019
|
Thank you @soyuka. |
fabpot
added a commit
that referenced
this pull request
Apr 10, 2019
…t property names are strings (soyuka) This PR was merged into the 4.2 branch. Discussion ---------- [Serializer] MetadataAwareNameConverter: Do not assume that property names are strings | Q | A | ------------- | --- | Branch? | 4.2 (class introduced in v4.2.3) | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | api-platform/core#2709 | License | MIT | Doc PR | n/a When this class was introduced, there was an assumption made about the type of `propertyNames` and therefore a `: ?string` return type was introduced in the fallbacks/normalization private methods. Because symfony doesn't use strict mode yet (compatibility issues with php IIRC), when using a non-string property name (for example the integer `0` which is a valid property name in an array), it will convert the integer to a string. This is not good, especially if you have a name converter that returns the given property name (ie no transformation) you'll have it's type changed which isn't correct. I've discovered this bug while working on adding this name converter in api platform (api-platform/core#2709). Commits ------- af1e136 MetadataAwareNameConverter: Do not assume that property names are strings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this class was introduced, there was an assumption made about the type of
propertyNamesand therefore a: ?stringreturn type was introduced in the fallbacks/normalization private methods. Because symfony doesn't use strict mode yet (compatibility issues with php IIRC), when using a non-string property name (for example the integer0which is a valid property name in an array), it will convert the integer to a string.This is not good, especially if you have a name converter that returns the given property name (ie no transformation) you'll have it's type changed which isn't correct.
I've discovered this bug while working on adding this name converter in api platform (api-platform/core#2709).