CS Fixes: Not double split with one array argument #31063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43029a4 to
9561b4a
Compare
|
Have you done the changes manually? Because we need to apply it first on 3.4 and then upwards. |
|
Yes, I used a macro in emacs. I can do a new pull request to 3.4 |
9561b4a to
cedf651
Compare
|
check #31064 |
fabpot
added a commit
that referenced
this pull request
Apr 10, 2019
…nrua) This PR was merged into the 3.4 branch. Discussion ---------- CS Fixes: Not double split with one array argument | Q | A | ------------- | --- | Branch? | 3.4 (master from #31063) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | None | License | MIT | Doc PR | None Keep to use the same CS in all the Symfony code base. Use: ```php $resolver->setDefaults([ 'compound' => false ]); ``` Instead of: ```php $resolver->setDefaults( [ 'compound' => false, ] ); ``` Keep the double split when the method has two or more arguments. I miss a PSR with this rule. Commits ------- a56bf55 CS Fixes: Not double split with one array argument
|
PRs for 3.4 and 4.2 are now merged up to master, please rebase to see if anything remains for master. |
Keep to use the same CS in all the Symfony code base.
Use:
```php
$resolver->setDefaults([
'compound' => false
]);
```
Instead of:
```php
$resolver->setDefaults(
[
'compound' => false,
]
);
```
Keep the double split when the method has two or more arguments.
I miss a PSR with this rule.
cedf651 to
027bd12
Compare
|
Done |
nicolas-grekas
approved these changes
Apr 11, 2019
fabpot
approved these changes
Apr 11, 2019
|
Thank you @rubenrua. |
fabpot
added a commit
that referenced
this pull request
Apr 11, 2019
…nrua)
This PR was merged into the 4.3-dev branch.
Discussion
----------
CS Fixes: Not double split with one array argument
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | None
| License | MIT
| Doc PR | None
Keep to use the same CS in all the Symfony code base.
Use:
```php
$resolver->setDefaults([
'compound' => false
]);
```
Instead of:
```php
$resolver->setDefaults(
[
'compound' => false,
]
);
```
Keep the double split when the method has two or more arguments.
I miss a PSR with this rule.
Commits
-------
027bd12 CS Fixes: Not double split with one array argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep to use the same CS in all the Symfony code base.
Use:
Instead of:
Keep the double split when the method has two or more arguments.
I miss a PSR with this rule.