[Dotenv] Improve Dotenv messages #31070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Apr 11, 2019
|
Thank you @XuanQuynh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 11, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Dotenv] Improve Dotenv messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | no | License | MIT | Doc PR | no This PR improves a little bit of some messages from #31062 The first, passive sentences may be more suitable here because the value couldn't change by itself. It is changed by us - human. The second, if we use **The default value of $usePutenv" argument of "%s\'s constructor**, we have to pass `__CLASS__` as the second parameter of `sprintf` function instead of `__METHOD__`. So, I suggest using **The default value of $usePutenv" argument of "%s"**. Finally, the deprecation warning of `Dotenv::__construct()` is very long. Let's separate it into 2 pieces for readable reason. Commits ------- e871a6a Improve Dotenv messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a little bit of some messages from #31062
The first, passive sentences may be more suitable here because the value couldn't change by itself. It is changed by us - human.
The second, if we use The default value of $usePutenv" argument of "%s's constructor, we have to pass
__CLASS__as the second parameter ofsprintffunction instead of__METHOD__. So, I suggest using The default value of $usePutenv" argument of "%s".Finally, the deprecation warning of
Dotenv::__construct()is very long. Let's separate it into 2 pieces for readable reason.