#30998 Fix deprecated setCircularReferenceHandler call #31073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the issue exists also on 3.4, isn't it? |
|
No, the deprecation is from 4.2 onward: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php#L142 Should my PR be PHP5.5 compatible for v4.2? |
|
Oh, sorry. 4.2 is PHP7.1, so all good then. |
nicolas-grekas
approved these changes
Apr 11, 2019
|
Thank you @dhaarbrink. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 11, 2019
…aarbrink) This PR was squashed before being merged into the 4.3-dev branch (closes #31073). Discussion ---------- #30998 Fix deprecated setCircularReferenceHandler call | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30998 | License | MIT Instead of calling the `setCircularReferenceHandler()` method, it puts the handler in the default context. Commits ------- 3a68040 #30998 Fix deprecated setCircularReferenceHandler call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling the
setCircularReferenceHandler()method, it puts the handler in the default context.