[HttpFoundation] Make MimeTypeExtensionGuesser case insensitive #31084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Apr 12, 2019
src/Symfony/Component/HttpFoundation/File/MimeType/MimeTypeExtensionGuesser.php
Outdated
Show resolved
Hide resolved
|
this needs a patch for master as well, where |
|
@vermeirentony can you add a test case please? |
|
@nicolas-grekas |
|
@vermeirentony Thanks for the contribution, I think by testcase Nicolas was meaning a test directly in the framework with PHPUnit, could you do that please ? |
|
@Simperfit sure, will write one later today |
|
@nicolas-grekas I just added the unit test |
ro0NL
approved these changes
Apr 15, 2019
nicolas-grekas
approved these changes
Apr 15, 2019
fabpot
approved these changes
Apr 15, 2019
|
@vermeirentony Can you squash your commits before merging? Right now, you've used 2 different identities for your commits. You probably need to keep the one here on Github. |
|
@fabpot squashed the 3 commits into one |
Simperfit
approved these changes
Apr 16, 2019
fabpot
pushed a commit
that referenced
this pull request
Apr 17, 2019
…itive (vermeirentony) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Make MimeTypeExtensionGuesser case insensitive | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Some mime types have a camelCase word in them. The Apache HTTPD project list items are all lower case. So I suggest making the $mimeType string lowercase while checking the array key. That way, we can keep the list in sync. Example: xlsm file mime type is `application/vnd.ms-excel.sheet.macroEnabled.12` The key that matches the xlsm extension in the `$defaultExtensions` array is `application/vnd.ms-excel.sheet.macroenabled.12` Example xlsm file: https://github.com/vermeirentony/xlsm-example Commits ------- e294ee6 Make MimeTypeExtensionGuesser case insensitive
|
Thank you @vermeirentony |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mime types have a camelCase word in them.
The Apache HTTPD project list items are all lower case.
So I suggest making the $mimeType string lowercase while checking the array key.
That way, we can keep the list in sync.
Example: xlsm file mime type is
application/vnd.ms-excel.sheet.macroEnabled.12The key that matches the xlsm extension in the
$defaultExtensionsarray isapplication/vnd.ms-excel.sheet.macroenabled.12Example xlsm file:
https://github.com/vermeirentony/xlsm-example