[VarDumper][Ldap] relax some locally failing tests #31132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 16, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
b00e509 to
88b2765
Compare
stof
reviewed
Apr 16, 2019
| @@ -8,6 +8,14 @@ class LdapTestCase extends TestCase | |||
| { | |||
| protected function getLdapConfig() | |||
| { | |||
| $h = @ldap_connect(getenv('LDAP_HOST'), getenv('LDAP_PORT')); | |||
There was a problem hiding this comment.
I suggest checking first whether we have values for these env variable. It does not make sense to try to connect if they were not provided.
There was a problem hiding this comment.
they are in the phpunit.xml.dist so that's not really needed
fabpot
pushed a commit
that referenced
this pull request
Apr 17, 2019
…las-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper][Ldap] relax some locally failing tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 88b2765 [VarDumper][Ldap] relax some locally failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.