Skip to content

[Routing] do not encode comma in query and fragment #31134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2019
Merged

[Routing] do not encode comma in query and fragment #31134

merged 1 commit into from
Apr 27, 2019

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Apr 16, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27266
License MIT
Doc PR

@Tobion
[Routing] allow comma and other reserved chars without special meaing…
76f6c97 
… to not be encoded in the query and fragment
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 16, 2019
@fabpot
Copy link
Member

fabpot commented Apr 27, 2019

Thank you @Tobion.

@fabpot fabpot merged commit 76f6c97 into symfony:master Apr 27, 2019
fabpot added a commit that referenced this pull request Apr 27, 2019
@fabpot
feature #31134 [Routing] do not encode comma in query and fragment (T…
1725a3c 
…obion)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Routing] do not encode comma in query and fragment

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27266
| License       | MIT
| Doc PR        |

Commits
-------

76f6c97 [Routing] allow comma and other reserved chars without special meaing to not be encoded in the query and fragment
@Tobion Tobion deleted the do-no-encode-command-in-query branch April 27, 2019 14:56
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Routing Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Tobion @fabpot @nicolas-grekas @OskarStark @carsonbot