Skip to content

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)" #31142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2019
Merged

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)" #31142

merged 1 commit into from
Apr 17, 2019

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Apr 17, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31136
License MIT
Doc PR n/a

Revert "bug symfony#30423 [Security] Rework firewall's access denied …
cd77f6f 
…rule (dimabory)"

This reverts commit fd1408b, reversing
changes made to b93d2bf.
@chalasr chalasr added this to the 3.4 milestone Apr 17, 2019
@curry684
Copy link
Contributor

So idea is to push this to 3.4 and 4.2 but not master right? Or should we just delay the real fix until 5.0 is branched?

@fabpot
Copy link
Member

fabpot commented Apr 17, 2019

I'm fine with having it in master/4.3.

@curry684
Copy link
Contributor

Yes so we agree the revert should only be in 3.4 and 4.2, and the fix stays in master/4.3 indeed 😄

@chalasr chalasr mentioned this pull request Apr 17, 2019
Closed
@fabpot
Copy link
Member

fabpot commented Apr 17, 2019

We will need a new PR for master though.

@dimabory
Copy link
Contributor

We will need a new PR for master though.

@fabpot Should I take over this as an author of #30423?

@curry684
Copy link
Contributor

You could just resubmit the same PR with the upgrade and changelog notes that will be needed now.

@chalasr
Copy link
Member Author

chalasr commented Apr 17, 2019

@dimabory PR welcome with UPGRADE + CHANGELOG entries

@dimabory
Copy link
Contributor

@curry684, @chalasr Actually, the discussion can be moved to #30423 (someone is still commenting there)

@JarJak JarJak mentioned this pull request Apr 17, 2019
Merged
@fabpot fabpot merged commit cd77f6f into symfony:3.4 Apr 17, 2019
fabpot pushed a commit that referenced this pull request Apr 17, 2019
@nicolas-grekas
bug #31142 Revert "bug #30423 [Security] Rework firewall's access den…
55a21fb 
…ied rule (dimabory)" (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | #31136
| License       | MIT
| Doc PR        | n/a

Commits
-------

cd77f6f Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"
@nicolas-grekas
Copy link
Member

Thank you @chalasr
PR welcome on master now.

@chalasr chalasr deleted the revert-30423 branch April 17, 2019 15:38
This was referenced Apr 17, 2019
Merged
Merged
@nesk nesk mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Security Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@chalasr @curry684 @fabpot @dimabory @nicolas-grekas @carsonbot