ChoiceType callable deprecation after/before seems wrong #31143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Apr 17, 2019
0716a1d to
30814a5
Compare
|
The previous example does not look entirely wrong to me. Previously, you had to wrap the |
|
My old phrasing seems wrong then, something is quite strange
Le jeu. 18 avr. 2019 à 08:32, Christian Flothmann <notifications@github.com>
a écrit :
… The previous example does not look entirely wrong to me. Previously, you
had to wrap the range in a PropertyPath instance as it would have been
interpreted as the range()function in Symfony 3.4 and older. That's no
longer required in Symfony +4.0 as the string would always be interpreted
as a property path.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2KV4TYY3IYJ2JYOL3IHA3PRAIYLANCNFSM4HGUTLCQ>
.
|
|
Maybe we should just remove the |
|
@xabbuh yes, doing it. |
ro0NL
reviewed
Apr 18, 2019
|
This is ready. |
yceruto
reviewed
Apr 25, 2019
|
Thanks @yceruto for the review; |
That is on me 3 years ago !
|
@fabpot this is ready |
xabbuh
approved these changes
Jun 5, 2019
fabpot
approved these changes
Jun 5, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2019
… (Simperfit) This PR was merged into the 3.4 branch. Discussion ---------- ChoiceType callable deprecation after/before seems wrong | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Was looking at the upgrade file because I'm upgrade an app right now, and just see that mistake I made 3 years ago !! Commits ------- 11ee84c minor: ChoiceType callable deprecation after/before seems wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at the upgrade file because I'm upgrade an app right now, and just see that mistake I made 3 years ago !!