-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebserverBundle] Deprecate the bundle in favor of symfony local server #31217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebserverBundle] Deprecate the bundle in favor of symfony local server #31217
Conversation
That's for 4.4 I believe, and we should display nice runtime deprecation notices also. |
addc686
to
d30036d
Compare
If we go that way, we should maybe add a special case in flex to ease installing the binary? See symfony/flex#491 |
d30036d
to
f6c97a6
Compare
f6c97a6
to
396cc5e
Compare
I think it is bad idea. |
src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php
Outdated
Show resolved
Hide resolved
396cc5e
to
7307907
Compare
Status: Needs review |
@zorn-v The deprecation message mention that you can use the Symfony local web server. But you can use whatever you want indeed. I like the removal of web server bundle as the PHP built-in web server lacks too many needed features (concurrency, TLS support, HTTP/2, ...). |
Thank you @Simperfit. |
…fony local server (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [WebserverBundle] Deprecate the bundle in favor of symfony local server | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | to do <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Since most of the feature added to the symfony local server (using php-fpm) will be handy for all developers and as said in #25748 (comment), I agree that we should deprecate the WebserverBundle in favor of the [Symfony Local Server](https://symfony.com/doc/current/setup/symfony_server.html) cc @stof @fabpot Commits ------- 7307907 [WebserverBundle] Deprecate the bundle in favor of symfony local server
I would not deprecates |
There is one fairly important feature that lacks from the Symfony local web server. The ability to specify an IP address of the server. This is mainy useful when you want to bind the server to all network interfaces with |
Needed very rarely for local development... Maybe hint in deprecation note like BTW, I found out about "-S" option thanking symfony server start/run command ) just was wondering. |
WHY? God why? Who needs tls on local machine? Install nginx ffs, might aswell rename it to symfony global server, because that's what it is, it is system wide binary that I have to install beforehand. |
Reasons you might need these features:
You can indeed also install nginx locally (and then configure TLS locally if you want that part). That's not forbidden by this PR. This PR is about deprecating WebServerBundle, which is a wrapper around |
Indeed, I am using a docker-compose network of services (containers) with https://github.com/symfony/cli/issues/107 was closed as
https://github.com/symfony/cli/issues/128 is still open (no answer from team yet) (and https://github.com/symfony/cli/issues/183 is kinda related too) |
Use PS. |
@zorn-v Thanks, I tested that already, but that is not strictly equivalent (the WebServerBundle adds more options and a custom Edit: Of course not for production, only for development on local machine |
Nothing special PS. |
The actual reason to clutter developers' logs with this deprecation warning is to push them to use the closed-source "alternative" (https://github.com/symfony/cli/issues/37)
Nothing stops anyone from producing closed-source by-products or sell commercial services. Taking advantage of a large user-base trusting this software (and its open-source quality) to push a closed-source tool as the only development alternative is a really bad move I suggest you reconsider (the fact that this, mostly confidential, PR is already the 4th most down-voted one should be hint... until comments get closed here too) As one of the thousands of developers who won't install an opaque binary for their development, I strongly hope that maintenance PR for the webserver-bundle will not be discarded.
By chance this deprecation does not affect production servers. But from now on... who knows what could come next? NB: Just found https://www.reddit.com/r/PHP/comments/foqs7x/symfony_docs_make_it_look_like_you_have_to_use/ :
|
Since most of the feature added to the symfony local server (using php-fpm) will be handy for all developers and as said in #25748 (comment), I agree that we should deprecate the WebserverBundle in favor of the Symfony Local Server cc @stof @fabpot