[Form] Add Button type back to Form::getClickedButton docblock #31222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Apr 24, 2019
0a3ac5a to
b71d589
Compare
xabbuh
approved these changes
Jun 8, 2019
|
Thank you @billhance. |
xabbuh
added a commit
that referenced
this pull request
Jun 8, 2019
…cblock (Bill Hance) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Add Button type back to Form::getClickedButton docblock | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | In commit 56429a6 the `Button` type was removed from the return doc block. I suspect this was an oversight because, AFAIK, the [recommended way](https://symfony.com/doc/current/form/multiple_buttons.html) to check the name of a clicked button would require a return type of `Button` or `SubmitButton`. The effect is that our static analysis checks are failing. ``` Call to an undefined method Symfony\Component\Form\ClickableInterface::getName(). ``` Commits ------- b71d589 Added FormInterface to @return Form::getClickedButton docblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 56429a6 the
Buttontype was removed from the return doc block.I suspect this was an oversight because, AFAIK, the recommended way to check the name of a clicked button would require a return type of
ButtonorSubmitButton.The effect is that our static analysis checks are failing.