[Console] Commands with an alias should not be recognized as ambiguous when using register #31261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis and Appveyor failure are not related. |
|
2.8 is not maintained since a few months now, can you please rebase/retarget 3.4? |
4a38b3c to
b97f7fa
Compare
7970690 to
f375167
Compare
|
cc @chalasr |
|
AppVeyor Failure is not related. |
chalasr
requested changes
Apr 26, 2019
fa68f1f to
d56b88c
Compare
|
Status: Needs Review |
|
@chalasr ready for another round of review |
|
@chalasr done Status: Needs Review. |
d56b88c to
ae7ee46
Compare
chalasr
approved these changes
May 8, 2019
nicolas-grekas
approved these changes
May 9, 2019
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
May 9, 2019
…as ambiguous when using register (Simperfit) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Commands with an alias should not be recognized as ambiguous when using register | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25355 | License | MIT | Doc PR | I think when passing an alias, it should not be treated as a ambiguous command since it's configured to response to it. I've [pushed a commit](Simperfit/symfony-reproducer@2f5209a) that reproduce the bug and with this patch it does work. Commits ------- ae7ee46 [Console] Commands with an alias should not be recognized as ambiguous
chalasr
pushed a commit
that referenced
this pull request
May 14, 2019
…(Simperfit) This PR was submitted for the 4.3 branch but it was merged into the 4.4-dev branch instead (closes #31420). Discussion ---------- [Console] optimisation getting the command when finding | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Following discussion with @chalasr in here #31261 (comment), first commit will be deleted when the other PR is merged. Commits ------- 3d6b303 [Console] Optimisation on getting the command
This was referenced May 22, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think when passing an alias, it should not be treated as a ambiguous command since it's configured to response to it.
I've pushed a commit that reproduce the bug and with this patch it does work.