Skip to content

[WebServerBundle] Change the default pidfile location to cache directory #31280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2019
Merged

[WebServerBundle] Change the default pidfile location to cache directory #31280

merged 1 commit into from
Apr 29, 2019

Conversation

jschaedl
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29160
License MIT
Doc PR tbd.

@jschaedl jschaedl force-pushed the web-server-bundle_store-pidfile-project-dir branch from ae09416 to ee32c98 Compare April 26, 2019 20:36
@jschaedl jschaedl marked this pull request as ready for review April 26, 2019 20:43
@jschaedl jschaedl changed the title Changes default pidfile location to project dir #29160 [WebServerBundle] Changes default pidfile location to project dir #29160 Apr 26, 2019
@jschaedl jschaedl changed the title [WebServerBundle] Changes default pidfile location to project dir #29160 [WebServerBundle] Changes default pidfile location to project dir Apr 26, 2019
@jschaedl jschaedl changed the title [WebServerBundle] Changes default pidfile location to project dir [WebServerBundle] Change the default pidfile location to projectDir Apr 26, 2019
@chalasr chalasr added this to the next milestone Apr 26, 2019
@jschaedl jschaedl force-pushed the web-server-bundle_store-pidfile-project-dir branch from ee32c98 to 3aae37d Compare April 27, 2019 06:01
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 27, 2019 •
edited
Loading

I'm still on the side this should be somewhere in the var directory.

@jschaedl jschaedl force-pushed the web-server-bundle_store-pidfile-project-dir branch from 74bc733 to 2be7b89 Compare April 27, 2019 11:45
nicolas-grekas
nicolas-grekas previously approved these changes Apr 27, 2019
View reviewed changes
@nicolas-grekas nicolas-grekas dismissed their stale review April 27, 2019 13:29

tests are failing

@jschaedl jschaedl changed the title [WebServerBundle] Change the default pidfile location to projectDir [WebServerBundle] Change the default pidfile location to cache directory Apr 28, 2019
@jschaedl
Copy link
Contributor Author

@nicolas-grekas

tests are failing

Tests are fixed but the AppVeyor build is still failing... 😕

@nicolas-grekas
Copy link
Member

By the way, not sure it's a good idea to use the parent directory of the cache directory. It may not be writable.

same issue with getcwd(), yet this is for dev, I'd guess it's because this is never an issue with dev?

@fabpot fabpot force-pushed the web-server-bundle_store-pidfile-project-dir branch from 0022b33 to 2e14b6e Compare April 29, 2019 09:33
@fabpot
Copy link
Member

fabpot commented Apr 29, 2019

Thank you @jschaedl.

@fabpot fabpot merged commit 2e14b6e into symfony:master Apr 29, 2019
fabpot added a commit that referenced this pull request Apr 29, 2019
@fabpot
feature #31280 [WebServerBundle] Change the default pidfile location …
707b1df 
…to cache directory (jschaedl)

This PR was squashed before being merged into the 4.3-dev branch (closes #31280).

Discussion
----------

[WebServerBundle] Change the default pidfile location to cache directory

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29160   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | tbd.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

2e14b6e [WebServerBundle] Change the default pidfile location to cache directory
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@javiereguiluz javiereguiluz mentioned this pull request May 7, 2019
Closed
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
@jschaedl jschaedl deleted the web-server-bundle_store-pidfile-project-dir branch February 23, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed WebServerBundle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@jschaedl @nicolas-grekas @fabpot @xabbuh @chalasr @carsonbot