[TwigBridge] Fix deprecation on twig 2.9 #31281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b16f55b to
4c6e90a
Compare
4c6e90a to
ac8256b
Compare
|
seeing https://github.com/twigphp/Twig/blob/2e68b5fdc4b57860241528b4961cbbb5d3c7a917/src/NodeVisitor/NodeVisitorInterface.php#L34 was a bit confusing, it includes the deprecated type (false) still right? edit: oh it's fixed in the 3.x branch 🤔 |
ro0NL
reviewed
Apr 27, 2019
src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 27, 2019
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] Fix deprecation on twig 2.9 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes$ | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a should make travis green Commits ------- ac8256b [TwigBridge] Fix deprecation on twig 2.9
fabpot
added a commit
that referenced
this pull request
Apr 28, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] Require Twig ^1.40|^2.9 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | n/a | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Reverts #31281 Commits ------- 0e29e39 [TwigBridge] Require twig ^1.40|^2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should make travis green