[Messenger] Add WorkerStoppedEvent #31282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebd354 to
8b81fad
Compare
OskarStark
approved these changes
Apr 27, 2019
8b81fad to
4733c22
Compare
weaverryan
reviewed
Apr 27, 2019
4733c22 to
0e7898b
Compare
weaverryan
approved these changes
Apr 27, 2019
|
Thank you @chalasr. |
sroze
added a commit
that referenced
this pull request
Apr 28, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Add WorkerStoppedEvent | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a In 4.2, one was able to decorate a transport and hook into `TransportInterface::stop()` to perform some business tasks when the `messenger:consume` process gets killed. In 4.3 the `stop()` logic has been moved to `Worker` which cannot be decorated when used via `messenger:consume`. This PR adds a marker event dispatched when the worker is stopped to provide the same capability. Briefly discussed with @weaverryan. My use case: I have a temporary CSV file locally which grows while consuming jobs. This file is uploaded to AWS S3 and squashed once a while (every 5minutes). It is also uploaded when the `messenger:consume` process gets stopped (to store the remaining lines). For the former (time-based upload), I can listen on `WorkflowMessageHandledEvent` to make the upload happens in case the 5 minutes delay is elapsed. This solves the latter. Commits ------- 0e7898b [Messenger] Add WorkerStoppedEvent
25 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.2, one was able to decorate a transport and hook into
TransportInterface::stop()to perform some business tasks when themessenger:consumeprocess gets killed.In 4.3 the
stop()logic has been moved toWorkerwhich cannot be decorated when used viamessenger:consume.This PR adds a marker event dispatched when the worker is stopped to provide the same capability.
Briefly discussed with @weaverryan.
My use case:
I have a temporary CSV file locally which grows while consuming jobs.
This file is uploaded to AWS S3 and squashed once a while (every 5minutes). It is also uploaded when the
messenger:consumeprocess gets stopped (to store the remaining lines).For the former (time-based upload), I can listen on
WorkflowMessageHandledEventto make the upload happens in case the 5 minutes delay is elapsed. This solves the latter.