Make UrlTypes render as url types. #31284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you define a default protocol, you should be able to submit a protocol-less URL. Can you confirm? perhaps we can improve UX without a default protocol in core: personally i wouldnt mind deprecating the option either :) |
|
You mean that the behavior on 3.4 is good, but you target 4.2 here because of a bad merge? |
|
@ro0NL Okay, I understand now. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you have to declare an explicit option of
["default_protocol" => null]on every UrlType form element or it renders as atype="text". Seems like 2 merges tried to fix this from different ends with one forcing a default protocol and once changing to a text type if there is no default protocol, thus ensuring that url type are always changed to text types unless the above option is also passed, which is very counter-intuitive.This PR fixes that by no longer changing to text types if default_protocol is not null since we are always forcing a default now.