[Messenger] RoutableMessageBus route to default bus #31288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3e17df to
8fde9b3
Compare
sroze
suggested changes
Apr 28, 2019
505cc53 to
c15ba90
Compare
sroze
approved these changes
Apr 28, 2019
| if (!$this->busLocator->has($busNameStamp->getBusName())) { | ||
| throw new InvalidArgumentException(sprintf('Invalid bus name "%s" on BusNameStamp.', $busNameStamp->getBusName())); | ||
| if (!$this->busLocator->has($busName)) { | ||
| throw new InvalidArgumentException(sprintf('Bus name "%s" does not exists.', $busName)); |
There was a problem hiding this comment.
Suggested change
| throw new InvalidArgumentException(sprintf('Bus name "%s" does not exists.', $busName)); | |
| throw new InvalidArgumentException(sprintf('Bus named "%s" does not exist.', $busName)); |
| { | ||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage('does not contain a BusNameStamp'); | ||
| $this->expectExceptionMessage(sprintf('Bus name "%s" does not exists.', MessageBusInterface::class)); |
There was a problem hiding this comment.
Can you move these to annotations instead actually? It's more readable.
6ed20d8 to
8513c4f
Compare
36 tasks
8513c4f to
c4e5e83
Compare
|
Thank you @dirk39. |
fabpot
added a commit
that referenced
this pull request
May 1, 2019
…irk39) This PR was squashed before being merged into the 4.3-dev branch (closes #31288). Discussion ---------- [Messenger] RoutableMessageBus route to default bus | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31200 | License | MIT | Doc PR | Not needed Hi! I modified the behaviour of RoutableMessageBus to route message without BusNameStamp to default bus instead of raise an exception. Made with ❤️ by [](https://www.meetup.com/it-IT/Open-Source-Saturday-Milano/) Commits ------- c4e5e83 [Messenger] RoutableMessageBus route to default bus
|
Comments addressed in 2eda6ff |
25 tasks
Merged
Tobion
added a commit
that referenced
this pull request
May 11, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix routable message bus default bus | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | not needed In #31288, we gave the `RoutableMessageBus` a "default" bus. We did that by using the `MessageBusInterface` service in the locator. But, no such service exists - I think that was just a huge oversight (and maybe @dirk39 named a bus this in the project he was testing on?). The services in the locator are very simply the keys under `framework.messenger.buses` or the default, which is a single `messenger.bus.default` id. There is an alias in the container for `MessageBusInterface`, but this is not added to the locator (and adding it would be a bit awkward, as `MessengerPass` is in the component and the interface alias is entirely a framework thing). Cheers! Commits ------- 42e0536 Changing how RoutableMessageBus fallback bus works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I modified the behaviour of RoutableMessageBus to route message without BusNameStamp to default bus instead of raise an exception.
Made with ❤️ by