-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[TwigBundle] Use the apply tag instead of the filter tag #31290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The bug can be observed like this:
|
This deprecation is breaking our test suite on 3.4 https://travis-ci.org/symfony/symfony/jobs/525267589#L5408 (not master because the test is marked a legacy there). Bumping the twig requirement to |
I contributed it on that branch because I did not observe the deprecation on 3.4, but I must have forgotten to update my vendors. The fix will be harder on 3.4 indeed: is there a way to detect if a tag is available from Twig? |
There is no AFAIK :/ |
In case he does find a solution, what should we do with my PR? Close it and let his solution apply 🥁 ? Or is it best to bump the dependency? |
I think we would better not bump it (in case Twig 2.9 is not ready in time for the Symfony 4.3 releases) but I don't know tbh :) Let's keep this open until we have more inputs |
You can bump the minimum version. I will release the new versions of Twig 1.x and 2.x in the next few days. |
On 3.4 :) |
cc68892
to
56fe300
Compare
The filter has been deprecated in favor of the apply tag since Twig 2.9, see https://twig.symfony.com/doc/2.x/tags/filter.html (apply does not seem to have its own documentation page yet).
56fe300
to
9c11b98
Compare
cc @xabbuh |
I added a warning above, cause I think this should not be merged yet, right?
|
Thank you @greg0ire. |
…greg0ire) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle] Use the apply tag instead of the filter tag The filter has been deprecated in favor of the apply tag since Twig 2.9, see https://twig.symfony.com/doc/2.x/tags/filter.html (apply does not seem to have its own documentation page yet). | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a ⚠ Note: don't merge until Twig 2.9 and 1.40 are released, or this will block symfony releases ⚠ Commits ------- 9c11b98 Use the apply tag instead of the filter tag
The filter has been deprecated in favor of the apply tag since Twig 2.9,
see https://twig.symfony.com/doc/2.x/tags/filter.html (apply does not
seem to have its own documentation page yet).
⚠ Note: don't merge until Twig 2.9 and 1.40 are released, or this will block symfony releases ⚠