[Form] Add intl/choice_translation_locale option to TimezoneType #31294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
May 9, 2019
nicolas-grekas
added a commit
that referenced
this pull request
May 9, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Intl] Revise timezone name generation | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (inlcluding intl-data group) | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This is the final polishing needed for #31294 :) I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach `LocaleDataGenerator` already follows. I was trying to be clever and filter based on inheritance in a single process; bad idea. Includes ro0NL@31591d0 (ref #31432) Commits ------- bfdb4ed [Intl] Revise timezone name generation
|
Time for rebase. |
|
4.3? would makes sense as we added all the timezone related infra in 4.3 already, which purpose it was to support this feature 😅 |
nicolas-grekas
previously approved these changes
May 9, 2019
|
Figured it out, locally i invoked testing the whole suite, shows we have a global state issue with the default locale. Last commit should do, not sure why it starts failing now, as other intl types have the same test :/ |
stof
reviewed
May 9, 2019
...ponent/Form/Tests/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformerTest.php
Outdated
Show resolved
Hide resolved
fabpot
added a commit
that referenced
this pull request
May 10, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Restore default locale during tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31294 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This fixes the failing tests in #31294 Commits ------- 7fce86f [Form] Restore default locale during tests
|
All good (failures unrelated) |
fabpot
approved these changes
May 13, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 13, 2019
…mezoneType (ro0NL) This PR was merged into the 4.3 branch. Discussion ---------- [Form] Add intl/choice_translation_locale option to TimezoneType | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28836 | License | MIT | Doc PR | symfony/symfony-docs#11503 final step :) for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295 having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future. includes #31434 Commits ------- 001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
final step :)
for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295
having a special built in
group_by' => 'gmt_offset'util would be nice, and can be done in the future.includes #31434