Skip to content

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Apr 27, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? n/a
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

#30888 added some tests on master which fail when property-info <3.4.13 is installed.
This bumps the constraint on 3.4 which will fix the low-deps build once merged up to master.

@chalasr chalasr added this to the 3.4 milestone Apr 27, 2019
@chalasr chalasr requested a review from dunglas as a code owner April 27, 2019 21:25
@fabpot
Copy link
Member

fabpot commented Apr 28, 2019

Thank you @chalasr.

@fabpot fabpot merged commit d25f650 into symfony:3.4 Apr 28, 2019
fabpot added a commit that referenced this pull request Apr 28, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | n/a
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

#30888 added some tests on master which fail when `property-info <3.4.13` is installed.
This bumps the constraint on 3.4 which will fix the low-deps build once merged up to master.

Commits
-------

d25f650 [Serializer] Fix tests
@chalasr chalasr deleted the serializer-tests branch April 28, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants