Skip to content

[Intl] Fix LocaleDataGenerator #31301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019
Merged

[Intl] Fix LocaleDataGenerator #31301

merged 1 commit into from
Apr 29, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Apr 28, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Forgotten in #28846

The getName() method for scripts/regions/languages is stilled needed during locale generation.

@fabpot
Copy link
Member

fabpot commented Apr 29, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 137ce3f into symfony:master Apr 29, 2019
fabpot added a commit that referenced this pull request Apr 29, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Intl] Fix LocaleDataGenerator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Forgotten in #28846

The `getName()` method for scripts/regions/languages is stilled needed during locale generation.

Commits
-------

137ce3f [Intl] Fix LocaleDataGenerator
@ro0NL ro0NL deleted the intl-fix branch April 29, 2019 06:46
@nicolas-grekas nicolas-grekas modified the milestones: 4.2, next, 4.3 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants