Skip to content

[Validator] Extra timezone tests #31324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019
Merged

[Validator] Extra timezone tests #31324

merged 1 commit into from
Apr 30, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Apr 30, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

This PR adds some extra tests, to cover the timezone domain. Ideally to go before #31292 :)

@fabpot
Copy link
Member

fabpot commented Apr 30, 2019

Thank you @ro0NL.

weaverryan pushed a commit to weaverryan/symfony that referenced this pull request Apr 30, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Extra timezone tests

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR adds some extra tests, to cover the timezone domain. Ideally to go before symfony#31292 :)

Commits
-------

4f2bba7 [Validator] Extra timezone tests
@fabpot fabpot merged commit 4f2bba7 into symfony:master Apr 30, 2019
@ro0NL ro0NL deleted the tz-validator-test branch April 30, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants