[Workflow] Fixed dumping when many transition with same name exist #31331
+68
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure are not related |
javiereguiluz
approved these changes
Apr 30, 2019
OskarStark
approved these changes
Apr 30, 2019
fabpot
approved these changes
May 1, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
May 1, 2019
…me exist (lyrixx)
This PR was merged into the 3.4 branch.
Discussion
----------
[Workflow] Fixed dumping when many transition with same name exist
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no>
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
---
With this configuration:
```yaml
framework:
workflows:
foobar:
type: workflow
supports:
- stdClass
initial_place: a
places:
- a
- b
- c
- cancelled
transitions:
- name: a-b
from: a
to: b
- name: b-c
from: b
to: c
- name: cancel
from: a
to: cancelled
- name: cancel
from: b
to: cancelled
- name: cancel
from: c
to: cancelled
```
before:
After:
Commits
-------
312a456 [Workflow] Fixed dumping when many transition with same name exist
fabpot
reviewed
May 1, 2019
| foreach ($transitions as $place) { | ||
| $code .= sprintf(" transition_%s [label=\"%s\", shape=box%s];\n", $this->dotize($place['name']), $place['name'], $this->addAttributes($place['attributes'])); | ||
| foreach ($transitions as $i => $place) { | ||
| $code .= sprintf(" transition_%d [label=\"%s\", shape=box%s];\n", $this->dotize($i), $place['name'], $this->addAttributes($place['attributes'])); |
There was a problem hiding this comment.
@lyrixx We could remove the call to dotize here as $i is always an integer, right?
There was a problem hiding this comment.
Nevermind, in 4.2, we are using a hash, so a string (so I'm going to change %d to %s in 4.2).
|
Is this actually what you want? Because this makes large workflows very messy. Why not merge the transitions and show them with 1 arrow like this: This can be achieved easily with this change: protected function findEdges(Definition $definition)
{
$dotEdges = [];
foreach ($definition->getTransitions() as $i => $transition) {
foreach ($transition->getFroms() as $from) {
- $dotEdges[] = [
+ $dotEdges[$from.$transition->getName().'from'] = [
'from' => $from,
'to' => $transition->getName(),
'direction' => 'from',
'transition_number' => $i,
];
}
foreach ($transition->getTos() as $to) {
- $dotEdges[] = [
+ $dotEdges[$transition->getName().$to.'to'] = [
'from' => $transition->getName(),
'to' => $to,
'direction' => 'to',
'transition_number' => $i,
];
}
}
return $dotEdges;
} |
|
@ruudk Because this graph is not accurate. According to this representation the I hope it's more clear :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this configuration:
before:
After:
