[Intl][Validator] Handle alias locales/timezones #31354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 4, 2019
xabbuh
reviewed
May 4, 2019
xabbuh
approved these changes
May 6, 2019
fabpot
approved these changes
May 6, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 6, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #31354). Discussion ---------- [Intl][Validator] Handle alias locales/timezones | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes (including intl-data group) | Fixed tickets | #31022 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> both timezones and locales have aliases (either thru deprecation/migration/etc.) for locales we compile a mapping, for timezones we dont. yet we can benefit partial alias support thru DateTimeZone, which knows about most timezone IDs already. both the timezone + locale validator already support aliases. Connsequently, we should support aliases in `Timezones::exists()` + `Locales::exists()` as well IMHO. so far so good; the catch is; with this PR `Locales::getName()` supports aliases, whereas `Timezones::getName()` doesnt. I think it's reasonable for now, until we compile the timezone mapping so we can widen the timezone ID conversion here. Commits ------- 0a9be0d [Intl][Validator] Handle alias locales/timezones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both timezones and locales have aliases (either thru deprecation/migration/etc.)
for locales we compile a mapping, for timezones we dont. yet we can benefit partial alias support thru DateTimeZone, which knows about most timezone IDs already.
both the timezone + locale validator already support aliases. Connsequently, we should support aliases in
Timezones::exists()+Locales::exists()as well IMHO.so far so good; the catch is; with this PR
Locales::getName()supports aliases, whereasTimezones::getName()doesnt. I think it's reasonable for now, until we compile the timezone mapping so we can widen the timezone ID conversion here.